Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop removed clang-tidy option #1810

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Drop removed clang-tidy option #1810

merged 1 commit into from
Jun 6, 2024

Conversation

bernhardmgruber
Copy link
Contributor

The AnalyzeTemporaryDestructors option was deprecated in clang-tidy 16 and removed in 18.

See also: https://reviews.llvm.org/D156303

@bernhardmgruber
Drop removed clang-tidy option
80ae8b8 
The AnalyzeTemporaryDestructors option was deprecated in clang-tidy 16 and removed in 18.

See also: https://reviews.llvm.org/D156303
@bernhardmgruber bernhardmgruber marked this pull request as ready for review June 5, 2024 16:48
@bernhardmgruber bernhardmgruber requested review from a team as code owners June 5, 2024 16:48
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

🟩 CI finished in 5h 00m: Pass: 100%/249 | Total: 1d 03h | Avg: 6m 30s | Max: 29m 37s | Hits: 99%/248310

  • 🟩 cub: Pass: 100%/131 | Total: 16h 59m | Avg: 7m 46s | Max: 29m 37s | Hits: 99%/109044

     
    🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total: 16h 28m | Avg:  8m 02s | Max: 29m 37s | Hits:  99%/102236
  🟩 arm64              Pass: 100%/8   | Total: 31m 10s | Avg:  3m 53s | Max:  4m 05s | Hits:  99%/6808  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total: 59m 56s | Avg:  3m 59s | Max: 13m 41s | Hits:  99%/11554 
  🟩 11.8               Pass: 100%/3   | Total: 13m 23s | Avg:  4m 27s | Max:  4m 35s | Hits:  99%/2553  
  🟩 12.4               Pass: 100%/113 | Total: 15h 46m | Avg:  8m 22s | Max: 29m 37s | Hits:  99%/94937 
🟩 cudacxx_full
  🟩 clang-cuda17       Pass: 100%/2   | Total:  6m 38s | Avg:  3m 19s | Max:  3m 24s | Hits: 100%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total: 59m 56s | Avg:  3m 59s | Max: 13m 41s | Hits:  99%/11554 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 13m 23s | Avg:  4m 27s | Max:  4m 35s | Hits:  99%/2553  
  🟩 nvcc12.4           Pass: 100%/111 | Total: 15h 39m | Avg:  8m 27s | Max: 29m 37s | Hits:  99%/93529 
🟩 cudacxx_name
  🟩 clang-cuda         Pass: 100%/2   | Total:  6m 38s | Avg:  3m 19s | Max:  3m 24s | Hits: 100%/1408  
  🟩 nvcc               Pass: 100%/129 | Total: 16h 52m | Avg:  7m 51s | Max: 29m 37s | Hits:  99%/107636
🟩 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 25m 25s | Avg:  4m 14s | Max:  5m 02s | Hits: 100%/4884  
  🟩 clang10            Pass: 100%/3   | Total: 13m 49s | Avg:  4m 36s | Max:  4m 49s | Hits: 100%/2559  
  🟩 clang11            Pass: 100%/4   | Total: 16m 09s | Avg:  4m 02s | Max:  4m 11s | Hits: 100%/3412  
  🟩 clang12            Pass: 100%/4   | Total: 15m 54s | Avg:  3m 58s | Max:  4m 15s | Hits: 100%/3412  
  🟩 clang13            Pass: 100%/4   | Total: 16m 07s | Avg:  4m 01s | Max:  4m 10s | Hits:  99%/3412  
  🟩 clang14            Pass: 100%/4   | Total: 16m 49s | Avg:  4m 12s | Max:  4m 21s | Hits: 100%/3412  
  🟩 clang15            Pass: 100%/4   | Total: 16m 44s | Avg:  4m 11s | Max:  4m 33s | Hits: 100%/3404  
  🟩 clang16            Pass: 100%/4   | Total: 16m 36s | Avg:  4m 09s | Max:  4m 15s | Hits: 100%/3404  
  🟩 clang17            Pass: 100%/26  | Total:  5h 29m | Avg: 12m 41s | Max: 29m 37s | Hits: 100%/21832 
  🟩 gcc6               Pass: 100%/2   | Total:  6m 16s | Avg:  3m 08s | Max:  3m 12s | Hits:  99%/1550  
  🟩 gcc7               Pass: 100%/6   | Total: 21m 28s | Avg:  3m 34s | Max:  4m 09s | Hits:  99%/4887  
  🟩 gcc8               Pass: 100%/6   | Total: 21m 38s | Avg:  3m 36s | Max:  4m 11s | Hits:  99%/4887  
  🟩 gcc9               Pass: 100%/6   | Total: 22m 14s | Avg:  3m 42s | Max:  4m 18s | Hits:  99%/4887  
  🟩 gcc10              Pass: 100%/4   | Total: 16m 50s | Avg:  4m 12s | Max:  4m 39s | Hits:  99%/3412  
  🟩 gcc11              Pass: 100%/7   | Total: 30m 27s | Avg:  4m 21s | Max:  4m 50s | Hits:  99%/5957  
  🟩 gcc12              Pass: 100%/4   | Total: 18m 03s | Avg:  4m 30s | Max:  4m 56s | Hits:  99%/3404  
  🟩 gcc13              Pass: 100%/28  | Total:  5h 31m | Avg: 11m 49s | Max: 28m 30s | Hits:  99%/23828 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 14m 15s | Avg:  4m 45s | Max:  4m 49s | Hits: 100%/2331  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 13m 41s | Avg: 13m 41s | Max: 13m 41s | Hits:  98%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 21m 46s | Avg: 10m 53s | Max: 10m 59s | Hits:  98%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 34m 21s | Avg: 11m 27s | Max: 12m 03s | Hits:  98%/2085  
🟩 cxx_name
  🟩 clang              Pass: 100%/59  | Total:  7h 47m | Avg:  7m 55s | Max: 29m 37s | Hits:  99%/49731 
  🟩 gcc                Pass: 100%/63  | Total:  7h 48m | Avg:  7m 25s | Max: 28m 30s | Hits:  99%/52812 
  🟩 Intel              Pass: 100%/3   | Total: 14m 15s | Avg:  4m 45s | Max:  4m 49s | Hits: 100%/2331  
  🟩 MSVC               Pass: 100%/6   | Total:  1h 09m | Avg: 11m 38s | Max: 13m 41s | Hits:  98%/4170  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total: 16h 59m | Avg:  7m 46s | Max: 29m 37s | Hits:  99%/109044
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  7h 23m | Avg:  4m 28s | Max: 13m 41s | Hits:  99%/81812 
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  2h 09m | Avg: 16m 07s | Max: 18m 28s | Hits:  99%/6808  
  🟩 GraphCapture       Pass: 100%/8   | Total:  1h 51m | Avg: 13m 59s | Max: 16m 49s | Hits:  99%/6808  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 04m | Avg: 15m 35s | Max: 18m 38s | Hits:  99%/6808  
  🟩 TestGPU            Pass: 100%/8   | Total:  3h 30m | Avg: 26m 18s | Max: 29m 37s | Hits:  99%/6808  
🟩 os
  🟩 ubuntu18.04        Pass: 100%/14  | Total: 46m 15s | Avg:  3m 18s | Max:  3m 39s | Hits:  99%/10859 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  2h 26m | Avg:  4m 10s | Max:  5m 02s | Hits:  99%/29855 
  🟩 ubuntu22.04        Pass: 100%/76  | Total: 12h 37m | Avg:  9m 57s | Max: 29m 37s | Hits:  99%/64160 
  🟩 windows2022        Pass: 100%/6   | Total:  1h 09m | Avg: 11m 38s | Max: 13m 41s | Hits:  98%/4170  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 13m 23s | Avg:  4m 27s | Max:  4m 35s | Hits:  99%/2553  
  🟩 90a                Pass: 100%/4   | Total: 13m 32s | Avg:  3m 23s | Max:  3m 32s | Hits:  99%/3404  
🟩 std
  🟩 11                 Pass: 100%/34  | Total:  4h 00m | Avg:  7m 05s | Max: 29m 37s | Hits:  99%/28503 
  🟩 14                 Pass: 100%/37  | Total:  4h 41m | Avg:  7m 37s | Max: 28m 27s | Hits:  99%/30588 
  🟩 17                 Pass: 100%/36  | Total:  4h 36m | Avg:  7m 40s | Max: 26m 02s | Hits:  99%/29822 
  🟩 20                 Pass: 100%/24  | Total:  3h 40m | Avg:  9m 11s | Max: 28m 30s | Hits:  99%/20131

  • 🟩 thrust: Pass: 100%/118 | Total: 10h 01m | Avg: 5m 05s | Max: 19m 52s | Hits: 99%/139266

     
    🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  9h 36m | Avg:  5m 14s | Max: 19m 52s | Hits:  99%/129822
  🟩 arm64              Pass: 100%/8   | Total: 25m 19s | Avg:  3m 09s | Max:  3m 17s | Hits:  99%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total: 57m 23s | Avg:  3m 49s | Max: 15m 07s | Hits:  99%/17705 
  🟩 11.8               Pass: 100%/3   | Total: 10m 35s | Avg:  3m 31s | Max:  3m 40s | Hits:  99%/3543  
  🟩 12.4               Pass: 100%/100 | Total:  8h 53m | Avg:  5m 20s | Max: 19m 52s | Hits:  99%/118018
🟩 cudacxx_full
  🟩 clang-cuda17       Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 37s | Hits: 100%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total: 57m 23s | Avg:  3m 49s | Max: 15m 07s | Hits:  99%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total: 10m 35s | Avg:  3m 31s | Max:  3m 40s | Hits:  99%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total:  8h 46m | Avg:  5m 22s | Max: 19m 52s | Hits:  99%/115658
🟩 cudacxx_name
  🟩 clang-cuda         Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 37s | Hits: 100%/2360  
  🟩 nvcc               Pass: 100%/116 | Total:  9h 54m | Avg:  5m 07s | Max: 19m 52s | Hits:  99%/136906
🟩 cxx_full
  🟩 clang9             Pass: 100%/6   | Total: 22m 18s | Avg:  3m 43s | Max:  4m 05s | Hits: 100%/7080  
  🟩 clang10            Pass: 100%/3   | Total: 12m 14s | Avg:  4m 04s | Max:  4m 11s | Hits: 100%/3540  
  🟩 clang11            Pass: 100%/4   | Total: 14m 21s | Avg:  3m 35s | Max:  3m 48s | Hits: 100%/4720  
  🟩 clang12            Pass: 100%/4   | Total: 14m 17s | Avg:  3m 34s | Max:  3m 39s | Hits: 100%/4720  
  🟩 clang13            Pass: 100%/4   | Total: 14m 11s | Avg:  3m 32s | Max:  3m 43s | Hits: 100%/4720  
  🟩 clang14            Pass: 100%/4   | Total: 14m 26s | Avg:  3m 36s | Max:  3m 52s | Hits: 100%/4720  
  🟩 clang15            Pass: 100%/4   | Total: 14m 03s | Avg:  3m 30s | Max:  3m 36s | Hits: 100%/4720  
  🟩 clang16            Pass: 100%/4   | Total: 14m 17s | Avg:  3m 34s | Max:  3m 39s | Hits: 100%/4720  
  🟩 clang17            Pass: 100%/18  | Total:  1h 48m | Avg:  6m 00s | Max: 15m 22s | Hits:  99%/21240 
  🟩 gcc6               Pass: 100%/2   | Total:  5m 42s | Avg:  2m 51s | Max:  3m 03s | Hits:  99%/2360  
  🟩 gcc7               Pass: 100%/6   | Total: 18m 45s | Avg:  3m 07s | Max:  3m 55s | Hits:  99%/7086  
  🟩 gcc8               Pass: 100%/6   | Total: 19m 17s | Avg:  3m 12s | Max:  3m 39s | Hits:  99%/7086  
  🟩 gcc9               Pass: 100%/6   | Total: 19m 04s | Avg:  3m 10s | Max:  3m 29s | Hits:  99%/7086  
  🟩 gcc10              Pass: 100%/4   | Total: 14m 08s | Avg:  3m 32s | Max:  3m 42s | Hits:  99%/4724  
  🟩 gcc11              Pass: 100%/7   | Total: 24m 19s | Avg:  3m 28s | Max:  3m 40s | Hits:  99%/8267  
  🟩 gcc12              Pass: 100%/4   | Total: 14m 33s | Avg:  3m 38s | Max:  4m 12s | Hits:  99%/4724  
  🟩 gcc13              Pass: 100%/20  | Total:  1h 52m | Avg:  5m 38s | Max: 14m 16s | Hits:  99%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 13m 10s | Avg:  4m 23s | Max:  4m 43s | Hits: 100%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 15m 07s | Avg: 15m 07s | Max: 15m 07s | Hits:  98%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 25m 09s | Avg: 12m 34s | Max: 13m 29s | Hits:  98%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  1h 31m | Avg: 15m 16s | Max: 19m 52s | Hits:  98%/7056  
🟩 cxx_name
  🟩 clang              Pass: 100%/51  | Total:  3h 48m | Avg:  4m 28s | Max: 15m 22s | Hits:  99%/60180 
  🟩 gcc                Pass: 100%/55  | Total:  3h 48m | Avg:  4m 09s | Max: 14m 16s | Hits:  99%/64953 
  🟩 Intel              Pass: 100%/3   | Total: 13m 10s | Avg:  4m 23s | Max:  4m 43s | Hits: 100%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  2h 11m | Avg: 14m 39s | Max: 19m 52s | Hits:  98%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total: 10h 01m | Avg:  5m 05s | Max: 19m 52s | Hits:  99%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  6h 38m | Avg:  4m 01s | Max: 15m 07s | Hits:  99%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 41m | Avg:  9m 13s | Max: 19m 52s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 41m | Avg: 12m 44s | Max: 15m 22s | Hits:  99%/9444  
🟩 os
  🟩 ubuntu18.04        Pass: 100%/14  | Total: 42m 16s | Avg:  3m 01s | Max:  3m 53s | Hits:  99%/16529 
  🟩 ubuntu20.04        Pass: 100%/35  | Total:  2h 06m | Avg:  3m 36s | Max:  4m 11s | Hits:  99%/41313 
  🟩 ubuntu22.04        Pass: 100%/60  | Total:  5h 01m | Avg:  5m 01s | Max: 15m 22s | Hits:  99%/70840 
  🟩 windows2022        Pass: 100%/9   | Total:  2h 11m | Avg: 14m 39s | Max: 19m 52s | Hits:  98%/10584 
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 10m 35s | Avg:  3m 31s | Max:  3m 40s | Hits:  99%/3543  
  🟩 90a                Pass: 100%/4   | Total: 12m 46s | Avg:  3m 11s | Max:  3m 22s | Hits:  99%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 02m | Avg:  4m 04s | Max: 13m 09s | Hits:  99%/35418 
  🟩 14                 Pass: 100%/34  | Total:  3h 07m | Avg:  5m 31s | Max: 16m 32s | Hits:  99%/40122 
  🟩 17                 Pass: 100%/33  | Total:  2h 54m | Avg:  5m 17s | Max: 19m 52s | Hits:  99%/38946 
  🟩 20                 Pass: 100%/21  | Total:  1h 57m | Avg:  5m 36s | Max: 19m 10s | Hits:  99%/24780

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental

🏃‍ Runner counts (total jobs: 249)
# Runner
178 linux-amd64-cpu16
40 linux-amd64-gpu-v100-latest-1
16 linux-arm64-cpu16
15 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber enabled auto-merge (squash) June 6, 2024 09:12
@bernhardmgruber bernhardmgruber merged commit 86d802d into NVIDIA:main Jun 6, 2024
553 checks passed
@bernhardmgruber bernhardmgruber deleted the tidy_obsolete branch June 6, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
cub For all items related to CUB
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @elstehle